Particle net monitoring dqm 124 x #39146
Conversation
|
A new Pull Request was created by @rgerosa (raffaele gerosa) for CMSSW_12_4_X. It involves the following packages:
@mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @jpata, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b784a/27029/summary.html Comparison SummarySummary:
|
|
+1 |
|
Just to note: strictly speaking, this changes the physics content (by adding a new tagger) of a closed release. Usually this is against our no-change policy (IIUC), as now the same campaing can contain potentially different configurations. I guess this can only be fine with the explicit confirmation of @cms-sw/pdmv-l2 if sample production has not yet actually started. |
|
+pdmv The MC production has not yet started. Let's put it in. |
|
+reconstruction
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
| float minDR = 1000; | ||
| int match_index = -1; | ||
| for (size_t jhlt = 0; jhlt < ntrigobjecttomatch_; jhlt++) { | ||
| if (jhlt >= jetPNETScoreSortedIndicesHLT.size()) |
There was a problem hiding this comment.
This was not there in #38748
| // match reco and hlt objects considering only the first ntrigobjecttomatch jets for both reco and HLT. Each of them must be matched | ||
| std::vector<int> matched_obj; | ||
| for (size_t jreco = 0; jreco < ntrigobjecttomatch_; jreco++) { | ||
| if (jreco >= jetPNETScoreSortedIndices.size()) |
There was a problem hiding this comment.
This was not there in #38748
There was a problem hiding this comment.
@perrotta indeed I added that check about vector size in order to be sure that there is no access to an invalid position. I will also propagate it back to the master branch tomorrow. Since this monitoring is important for pp collision we want to have it online as soon as the data-taking restarts. Hence, I hope this won't stall the approval of this PR
| continue; | ||
| float dR = reco::deltaR(selectedJets[jetPNETScoreSortedIndices.at(jreco)].p4(), | ||
| jetHLTRefs.at(jetPNETScoreSortedIndicesHLT.at(jhlt))->p4()); | ||
| if (dR < hltRecoDeltaRmax_ and dR < minDR) |
There was a problem hiding this comment.
I suspect that here you should have also updated minDR...
There was a problem hiding this comment.
Good catch .. indeed this has to be fixed. Updating the branch now
| min_jet_pt = 25, | ||
| max_jet_eta = 2.5, | ||
| ) | ||
|
|
||
| pfParticleNetAK4JetTags = boostedJetONNXJetTagsProducer.clone( | ||
| src = 'pfParticleNetAK4TagInfos', | ||
| preprocess_json = 'RecoBTag/Combined/data/ParticleNetAK4/CHS/V00/preprocess.json', | ||
| model_path = 'RecoBTag/Combined/data/ParticleNetAK4/CHS/V00/particle-net.onnx', |
There was a problem hiding this comment.
This line is different in master?
There was a problem hiding this comment.
it didn't occur to me to check a line that was not changed in master or in the backport... :)
git blame tells me that #37964 changed the path, it was merged for CMSSW_12_5_0_pre3, so it's understandable it's different in 12_4_X.
Let me know if that didn't explain it.
cmsbuild
added
dqm-pending
pending-signatures
reconstruction-pending
tests-pending
and removed
fully-signed
tests-approved
labels
|
Pull request #39146 was updated. @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @jpata, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b784a/27175/summary.html Comparison SummarySummary:
|
|
+reconstruction
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR is a backport of the monitoring workflow in the offline DQM for the AK4 and AK8 ParticleNet based HLT triggers. The workflow runs over the HLTMonitor dataset only for pp collision data, it is switched off for HI as we don't need it.
The original PRs already merged in master are #39051 and #38748
We need a back port in order to include the monitoring in the next CMSSW 12-4-X release that will be used during pp data-taking.
This PR was tested on Run3 data from the HLTMonitor dataset as follows:
cmsDriver step2_data -s RAW2DIGI,L1Reco,RECO,DQM --eventcontent DQM --datatier DQMIO --conditions 124X_dataRun3_Express_v4 --era Run3 --geometry DB:Extended --process reRECO --filein file:/eos/cms/store/express/Run2022C/HLTMonitor/FEVTHLTALL/Express-v1/000/357/080/00000/001b6704-a4de-4adf-9d17-bd6721ad02ad.root -n -1 --data
cmsDriver step3_data -s HARVESTING:dqmHarvesting --harvesting AtRunEnd --conditions auto:run3_data --era Run3 --geometry DB:Extended --scenario pp --hltProcess reHLT --filein file:step2_RAW2DIGI_L1Reco_RECO_DQM.root --filetype DQM -n -1 --data --no_exec